Skip to content

Fix StackOverFlowError on multiplication between ScalarOperator and UniformScalar #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2025
Merged

Fix StackOverFlowError on multiplication between ScalarOperator and UniformScalar #300

merged 2 commits into from
Aug 21, 2025

Conversation

@albertomercurio
Copy link
Contributor

@albertomercurio albertomercurio commented Aug 12, 2025 •
edited
Loading

In this PR I fix the following error

using SciMLOperators
using LinearAlgebra

l = ScalarOperator(1)
Id = I

l*Id
ERROR: StackOverflowError:
Stacktrace:
 [1] *(α::ScalarOperator{Int64, SciMLOperators.FilterKwargs{…}}, x::UniformScaling{Bool})
   @ SciMLOperators ~/.julia/packages/SciMLOperators/Gd0Qg/src/scalar.jl:369
 [2] *(α::ScalarOperator{Int64, SciMLOperators.FilterKwargs{…}}, x::UniformScaling{Bool}) (repeats 79983 times)
   @ SciMLOperators ~/.julia/packages/SciMLOperators/Gd0Qg/src/scalar.jl:372
Some type information was truncated. Use `show(err)` to see complete types.

FIxes #266

@albertomercurio albertomercurio mentioned this pull request Aug 12, 2025
Closed
@ChrisRackauckas
Copy link
Member

ChrisRackauckas commented Aug 12, 2025

Needs a test

@albertomercurio
Copy link
Contributor Author

albertomercurio commented Aug 19, 2025

Done

@ChrisRackauckas
Copy link
Member

ChrisRackauckas commented Aug 19, 2025

looks like alloc test fails?

@albertomercurio
Copy link
Contributor Author

albertomercurio commented Aug 19, 2025

Only the LTS case, as in all the previous PRs starting from #288, for what I can see. That should be related to AddedOperator rather than this fix on ScalarOperator

@ChrisRackauckas ChrisRackauckas merged commit 3ffe8cd into SciML:master Aug 21, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SciMLOperators 0.3.13 ScalarOperator UniformScaling mulitplication stackoverflow

2 participants

@albertomercurio @ChrisRackauckas